Changeset 11608

Timestamp:

11/10/08 14:30:31 (8 weeks ago)

Author:

juruen@…

Message:

+ Bugfix. Set loginShell when adding users. By default it takes /bin/false
but users can change it using /etc/ebox/80samba.conf

Location:

trunk/client/samba

Files:

• ChangeLog (modified) (1 diff)
• conf/80samba.conf (modified) (1 diff)
• src/EBox/SambaLdapUser.pm (modified) (4 diffs)

trunk/client/samba/ChangeLog

@@ -4 +4 @@
 0.12.99
         + New release
+0.12.5
+        + Bugfix. Set loginShell when adding users. By default it takes /bin/false
+        but users can change it using /etc/ebox/80samba.conf
 0.12.4
         + Bugfix. Check and correct if there is a user or group with a wrong SID.

trunk/client/samba/conf/80samba.conf

@@ -21 +21 @@
 # enable quota support
 enable_quota = yes
+
+# default login shell for users
+login_shell = /bin/false

trunk/client/samba/src/EBox/SambaLdapUser.pm

@@ -49 +49 @@
 use constant GECOS              => 'Ebox file sharing user '; 
 use constant USERGROUP          => 513;
+use constant DEFAULT_SHELL      => '/bin/false';
 # Home path for users and groups
 use constant BASEPATH          => '/home/samba';
@@ -125 +126 @@
 
                sambaAcctFlags       => SMBACCTFLAGS,
+
+               loginShel            => _loginShell(),
               };
 
@@ -161 +164 @@
 
                                      sambaSID             => $sambaSID,
+                                    
 
                                      # gecos                => GECOS
@@ -1309 +1313 @@
 }
 
+sub _loginShell
+{
+        my $shell = EBox::Config::configkey('login_shell');
+
+        if (defined($shell)) {
+                return $shell;
+        } else {
+                return DEFAULT_SHELL;
+        }
+}
 1;