Changeset 11550 for trunk

Show
Ignore:
Timestamp:
11/03/08 09:13:07 (2 months ago)
Author:
javier.amor.garcia@…
Message:

better control of runnign status when ther are not any daemon enabled

Files:
1 modified

Legend:

Unmodified
Added
Removed
  • trunk/client/openvpn/src/EBox/OpenVPN.pm

    r11515 r11550  
    916916        return 1; 
    917917    }elsif ($self->service) { 
    918         my @activeUserDaemons = 
    919           grep { (not $_->service) and (not $_->internal) } $self->daemons; 
    920         return @activeUserDaemons == 0 ? 1 : 0; 
     918        my @activeDaemons = grep { (not $_->service)  } $self->daemons; 
     919        return (@activeDaemons == 0) ? 1 : 0; 
    921920    } 
    922921 
     
    927926{ 
    928927    my ($self) = @_; 
    929     my @userDaemons = grep { not $_->internal } $self->daemons; 
    930  
    931     foreach my $userDaemon (@userDaemons) { 
    932         return 1 if $userDaemon->running; 
    933     } 
    934  
    935     return 
    936       0;   # XXX control that there isn't any user daemon incorrectly running 
     928 
     929 
     930    my $noneDaemonEnabled = 1; 
     931     
     932    my @daemons =  $self->daemons; 
     933    foreach my $daemon (@daemons) { 
     934        next if $daemon->internal(); 
     935 
     936        return 1 if $daemon->running; 
     937         
     938        if ($daemon->service()) { 
     939            $noneDaemonEnabled = 0; 
     940        } 
     941    } 
     942 
     943 
     944    if ($noneDaemonEnabled) { 
     945        return 1 if $self->service() 
     946    } 
     947 
     948    return 0;   # XXX control that there isn't any user daemon incorrectly running 
    937949} 
    938950